Tasks for guided setup #39951

rezkiy37 · 2024-04-09T15:36:36Z

Details

The PR introduces new onboarding flow. The app uses the new API command CompleteGuidedSetup and pass new tasks and message's optimistic data, on behalf of Concierge. After, the app redirects user to root screen.

Fixed Issues

$ #38771
PROPOSAL: N/A

Tests

Note: To test with an existing user, you can initiate the flow from Settings > Troubleshoot > Onboarding Flow.

With the creation of a workspace (Track business expenses..., Manage my team’s...)

Open the app with an entire new user.
Verify that the "What do you want to do today?" modal appears.
Select any tutorial.
Click on "Continue".
Verify that the "What’s your name?" modal appears.
Enter any names.
Click on "Continue".
Verify that the "Where do you work?" modal appears.
Enter any name.
Click on "Continue".
Verify that the app redirects to the home page.
Open the Concierge chat.
Verify that the app has generated the proper messages.
Verify that the app has created a workspace with the previously entered name.
Verify that attachment messages are replaced with videos, once the backend sends an update.

Without the creation of a workspace (others)

Open the app with an entire new user.
Verify that the "What do you want to do today?" modal appears.
Select any tutorial.
Click on "Continue".
Verify that the "What’s your name?" modal appears.
Enter any names.
Click on "Continue".
Verify that the app redirects to the home page.
Open the Concierge chat.
Verify that the app has generated the proper messages.
Verify that attachment messages are replaced with videos, once the backend sends an update.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Chrome.Track.mp4

Chrome.Chat.mp4

MacOS: Desktop

Desktop.mp4

…tructure for onboarding

…m/barttom/App-expensify into feature/38771-tasks-for-guided-setup

…tructure for onboarding

…m/barttom/App-expensify into feature/38771-tasks-for-guided-setup

…ture/38771-tasks-for-guided-setup

rezkiy37 · 2024-04-19T13:40:22Z

Autocompleted tasks integrated - b1c34f1.

Details

Autocompleted.mp4

rayane-djouah · 2024-04-19T22:13:14Z

Update:

PR is LGTM, and tests well.

We are waiting now for a response regarding #39951 (comment) and #39951 (comment).
And there are merge conflicts that need to be fixed.

Also, There are known backend bugs #39951 (comment) and #39951 (comment), but these should be NAB for this PR.

rayane-djouah · 2024-04-20T00:19:14Z

Also, cc'ing @Expensify/design to review the PR

mountiny · 2024-04-20T12:30:27Z

Also, There are known backend bugs #39951 (comment) and #39951 (comment), but these should be NAB for this PR.

Yep noting these are known

We are moving to using a new NVP: nvp_onboarding and actually I have added it only to the new command as I forgot we have two different commands for now, so in the enablement PR #39687 the onboarding is not considered as done 🤦 once finished, only here since the api command is different.

I think that the changes here are minor and we could merge this first and then retest the enablement of the flow.

@rayane-djouah could you complete the checklist?

rayane-djouah

LGTM

mountiny

Non blocking comments, I would love to get this merged to main before we enable the onboarding flow

mountiny · 2024-04-20T15:32:29Z

src/libs/Navigation/AppNavigator/AuthScreens.tsx

@@ -369,7 +369,7 @@ function AuthScreens({session, lastOpenedPublicRoomID, initialLastUpdateIDApplie
                    />
                    <RootStack.Screen
                        name={NAVIGATORS.ONBOARDING_MODAL_NAVIGATOR}
-                        options={onboardingScreenOptions}
+                        options={screenOptions.fullScreen}


This is I assume only for testing now, right?

I'm not sure about this one, onboardingScreenOptions come from here

const onboardingScreenOptions = useMemo(() => screenOptions.onboardingModalNavigator(shouldUseNarrowLayout), [screenOptions, shouldUseNarrowLayout]);

We can handle that in the follow up PR. thanks

src/libs/actions/Report.ts

src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

src/pages/OnboardingWork/BaseOnboardingWork.tsx

src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

mountiny · 2024-04-21T20:27:42Z

Thank you very much! I have tested this out and we are going to move the finishing touches to the Enablement PR.

I think we need to remove the videos for phase 1

Screen.Recording.2024-04-21.at.22.24.12.mp4

mountiny

Thanks @fabioh8010 for help ❤️

this PR should not influence the user experience on main. The flow is going to be enabled in this PR #39687 and we are going to work on Monday to clean everything up

OSBotify · 2024-04-21T20:38:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

src/CONST.ts

lanitochka17 · 2024-04-23T15:30:28Z

@rezkiy37 Hello
"What do you want to do today?" modal isn't appearing for a new user
Is this not implemented yet or is it a issue?

Thank you

rezkiy37 · 2024-04-23T15:39:19Z

@rezkiy37 Hello

"What do you want to do today?" modal isn't appearing for a new user

Is this not implemented yet or is it a issue?

Thank you

Hey, this flow depends on the backend value. As I know guys are fixing it now.
cc @mountiny

OSBotify · 2024-04-23T23:42:46Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allgandalf · 2024-06-17T06:44:06Z

src/pages/OnboardingWork/BaseOnboardingWork.tsx

+            // Only navigate to concierge chat when central pane is visible
+            // Otherwise stay on the chats screen.
+            if (isSmallScreenWidth) {
+                Navigation.navigate(ROUTES.HOME);


@rezkiy37 , why did we navigate to HOME instead of Concierge on small devices ? We have a GH issue here which has expected result that we should always navigate to concierge on all devices, was this intentional ? c.c. @mountiny and @rayane-djouah as they seem to have reviewed the PR

Yes, it was intentional. The doc says:

In the component OnboardingPurpose we can find a method that sends a message as the Concierge persona. After this action, the user should be able to see the video modal and be navigated to the root screen.

Cool thanks a lot 🙏

parasharrajat · 2024-06-20T07:21:52Z

src/libs/DateUtils.ts

    if (networkTimeSkew > 0) {
-        return getDBTime(new Date().valueOf() + networkTimeSkew);
+        return getDBTime(new Date(timestamp).valueOf() + networkTimeSkew);


Looks like this caused an issue #40724 preventing chat to scroll on new messages. When timestamp is not passed new Date('').valueOf() becomes NaN.

src/pages/OnboardingWork/BaseOnboardingWork.tsx

barttom and others added 30 commits April 5, 2024 12:52

feat: added new method for handliung onboarding, build new messages s…

53e0ca3

…tructure for onboarding

feat: call method

c34e8a2

Merge branch 'feat/38771/tasks-for-guided-setup' of https://github.co…

9068ffd

…m/barttom/App-expensify into feature/38771-tasks-for-guided-setup

feat: added new method for handliung onboarding, build new messages s…

880a34a

…tructure for onboarding

feat: call method

c396f2a

feat: added optimistic data

9ad3329

feat: added optimistic data

9cff1f4

feat: update method

1077782

Merge branch 'feat/38771/tasks-for-guided-setup' of https://github.co…

5e18a49

…m/barttom/App-expensify into feature/38771-tasks-for-guided-setup

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

b37c394

…ture/38771-tasks-for-guided-setup

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

28c66f3

…ture/38771-tasks-for-guided-setup

minor fixes of onboarding messages

4f8f78e

create CompleteGuidedSetupParams

e08f94d

integrate setDisplayName

202b111

extend functions in ReportUtils

fdb7f46

improve completeOnboarding

b60ed0d

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

f5486bb

…ture/38771-tasks-for-guided-setup

simplify CompleteGuidedSetupParams

4f291f0

add todo

a32e5ea

improve completeOnboarding

30678e2

pass timestamp into getDBTimeWithSkew

40c5676

pass createdOffset into buildOptimistic function

98175c1

fix bugs and improve completeOnboarding

64f4b92

avoid text escaping

80b6b48

add replies config

2a78251

pass mentionMessage and prettify

e97aa46

change ordering of pages

22cfe3b

fix bottom padding

f5cd44b

pass current user info

2adfe8f

remove line

1fb2411

integrate autocompleted tasks

b1c34f1

improve progress bar

c3360e0

rezkiy37 requested a review from rayane-djouah April 19, 2024 13:48

rayane-djouah approved these changes Apr 20, 2024

View reviewed changes

mountiny approved these changes Apr 20, 2024

View reviewed changes

mountiny requested changes Apr 20, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx Outdated Show resolved Hide resolved

mountiny mentioned this pull request Apr 20, 2024

[Onboarding - Stage 2] Onboarding Flow - enabled #39687

Merged

50 tasks

mountiny reviewed Apr 21, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx Outdated Show resolved Hide resolved

fabioh8010 added 2 commits April 21, 2024 11:19

Merge branch 'main' into feature/38771-tasks-for-guided-setup

4b0354a

Apply review changes

555861c

mountiny approved these changes Apr 21, 2024

View reviewed changes

mountiny merged commit 77a3c12 into Expensify:main Apr 21, 2024
16 checks passed

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

aldo-expensify reviewed Apr 23, 2024

View reviewed changes

src/CONST.ts Show resolved Hide resolved

izarutskaya mentioned this pull request Apr 23, 2024

[Guided Setup Stage 2] Keyboard not opened when navigating to enter name screen #40750

Closed

6 tasks

allgandalf reviewed Jun 17, 2024

View reviewed changes

parasharrajat reviewed Jun 20, 2024

View reviewed changes

parasharrajat mentioned this pull request Jun 20, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] CRITICAL: [UX Reliability] [$1000] Chat - Chat does not scroll down when sending messages #40724

Closed

6 tasks

brunovjk mentioned this pull request Jun 20, 2024

[WIP] Update Yellow Highlight Dismissal Behavior #43581

Closed

49 tasks

dominictb reviewed Jul 9, 2024

View reviewed changes

src/pages/OnboardingWork/BaseOnboardingWork.tsx Show resolved Hide resolved

allgandalf mentioned this pull request Jul 10, 2024

[HOLD for payment 2024-07-10] [$250] Concierge - User is not landed on Concierge chat via deeplink #43727

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tasks for guided setup #39951

Tasks for guided setup #39951

rezkiy37 commented Apr 9, 2024 •

edited

Loading

rezkiy37 commented Apr 19, 2024

rayane-djouah commented Apr 19, 2024 •

edited

Loading

rayane-djouah commented Apr 20, 2024

mountiny commented Apr 20, 2024

rayane-djouah left a comment

mountiny left a comment

mountiny Apr 20, 2024

fabioh8010 Apr 21, 2024

mountiny Apr 21, 2024

mountiny commented Apr 21, 2024

mountiny left a comment

OSBotify commented Apr 21, 2024

lanitochka17 commented Apr 23, 2024

rezkiy37 commented Apr 23, 2024

OSBotify commented Apr 23, 2024

allgandalf Jun 17, 2024

rezkiy37 Jun 17, 2024

allgandalf Jun 17, 2024

parasharrajat Jun 20, 2024

mountiny Jun 20, 2024

Tasks for guided setup #39951

Tasks for guided setup #39951

Conversation

rezkiy37 commented Apr 9, 2024 • edited Loading

Details

Fixed Issues

Tests

With the creation of a workspace (Track business expenses..., Manage my team’s...)

Without the creation of a workspace (others)

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 commented Apr 19, 2024

rayane-djouah commented Apr 19, 2024 • edited Loading

rayane-djouah commented Apr 20, 2024

mountiny commented Apr 20, 2024

rayane-djouah left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mountiny commented Apr 21, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 21, 2024

lanitochka17 commented Apr 23, 2024

rezkiy37 commented Apr 23, 2024

OSBotify commented Apr 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rezkiy37 commented Apr 9, 2024 •

edited

Loading

rayane-djouah commented Apr 19, 2024 •

edited

Loading